• Max Kellermann's avatar
    decoder/faad: remove workaround for ancient libfaad2 ABI bug · bc5a5357
    Max Kellermann authored
    Many years ago, FAAD had a serious ABI bug: the NeAACDecInit()
    prototype in its header declared the "samplerate" parameter to be
    "unsigned long *", but internally, the function assumed it was
    "uint32_t *" instead.  On 32 bit machines, that was no difference, but
    on 64 bit, this left one portion of the return value uninitialized;
    and worse, on big-endian, the wrong word was filled.  This bug had to
    be worked around in MPD (commit 9c4e97a6).
    
    A few months later, the bug was fixed in the FAAD CVS in commit 1.117
    on file libfaad/decoder.c; the commit message was:
    
     "Use public headers internally to prevent duplicate declarations"
    
    The commit message was too brief at best; the problem was not
    duplicate declarations, but a prototype mismatch.  No mention of the
    bug fix in the ChangeLog.
    
    The MPD project never learned about this bug fix, and so MPD would
    always pass a "uin32_t *" dressed up as a "unsigned long *".  Nearly 6
    years later, it's about time to fix this second ABI problem.  Let's
    kill the workaround!
    bc5a5357
Name
Last commit
Last update
android Loading commit data...
doc Loading commit data...
m4 Loading commit data...
scripts Loading commit data...
src Loading commit data...
systemd Loading commit data...
test Loading commit data...
.gitignore Loading commit data...
AUTHORS Loading commit data...
COPYING Loading commit data...
INSTALL Loading commit data...
Makefile.am Loading commit data...
NEWS Loading commit data...
README Loading commit data...
autogen.sh Loading commit data...
configure.ac Loading commit data...
mpd.svg Loading commit data...
valgrind.suppressions Loading commit data...