• Max Kellermann's avatar
    output/alsa: don't call snd_pcm_drain() if nothing was written · 4cdcaa86
    Max Kellermann authored
    Works around a problem where MPD goes into a busy loop because
    snd_pcm_drain() always returns `-EAGAIN` without making any progress
    (fixes #425).
    
    This problem was triggered by snd_pcm_drain() after snd_pcm_cancel()
    and snd_pcm_prepare(), but without submitting any data with
    snd_pcm_writei().
    
    I believe this is a kernel bug: in non-blocking mode, the kernel's
    snd_pcm_drain() function returns early.  In this mode, it only checks
    whether snd_pcm_drain_done() has been called already, but
    snd_pcm_drain_done() is never called if no data was submitted.
    
    In blocking mode, the following `for` loop detects this condition, so
    snd_pcm_drain_done() is not necessary, but without this extra check,
    we get `-EAGAIN` forever.
    4cdcaa86
Name
Last commit
Last update
..
httpd Loading commit data...
sles Loading commit data...
AlsaOutputPlugin.cxx Loading commit data...
AlsaOutputPlugin.hxx Loading commit data...
AoOutputPlugin.cxx Loading commit data...
AoOutputPlugin.hxx Loading commit data...
FifoOutputPlugin.cxx Loading commit data...
FifoOutputPlugin.hxx Loading commit data...
HaikuOutputPlugin.cxx Loading commit data...
HaikuOutputPlugin.hxx Loading commit data...
JackOutputPlugin.cxx Loading commit data...
JackOutputPlugin.hxx Loading commit data...
NullOutputPlugin.cxx Loading commit data...
NullOutputPlugin.hxx Loading commit data...
OSXOutputPlugin.cxx Loading commit data...
OSXOutputPlugin.hxx Loading commit data...
OpenALOutputPlugin.cxx Loading commit data...
OpenALOutputPlugin.hxx Loading commit data...
OssOutputPlugin.cxx Loading commit data...
OssOutputPlugin.hxx Loading commit data...
PipeOutputPlugin.cxx Loading commit data...
PipeOutputPlugin.hxx Loading commit data...
PulseOutputPlugin.cxx Loading commit data...
PulseOutputPlugin.hxx Loading commit data...
RecorderOutputPlugin.cxx Loading commit data...
RecorderOutputPlugin.hxx Loading commit data...
ShoutOutputPlugin.cxx Loading commit data...
ShoutOutputPlugin.hxx Loading commit data...
SndioOutputPlugin.cxx Loading commit data...
SndioOutputPlugin.hxx Loading commit data...
SolarisOutputPlugin.cxx Loading commit data...
SolarisOutputPlugin.hxx Loading commit data...
WinmmOutputPlugin.cxx Loading commit data...
WinmmOutputPlugin.hxx Loading commit data...
meson.build Loading commit data...