• Arkadiusz Hiler's avatar
    dinput/tests: Make overlapped format tests more robust. · 5cb70e73
    Arkadiusz Hiler authored
    Both Acquire() and event processing with DirectInput seem to be
    asynchronous. In most cases we can just keep hammering GetDeviceData()
    until the event gets processed.
    
    Things get pretty racy around Acquire() though. If we fire event right
    after the device is acquired we can find ourselves in one of the three
    situations:
    
    1. Event happened after acquiring has completed - the wait will suffice.
    
    2. Event happened before acquiring did any real work - the device will
       pick up the state as if the event was processed, but there's nothing
       in GetDeviceData(). Because of that we cannot fail on wait.
    
    3. Event happened somewhere in the middle of acquiring - we ended up
       both missing the event for GetDeviceData() and we have outdated
       state. Sending event again will register as if the button was not
       already pressed.
    
    This change covers all three scenarios.
    Signed-off-by: 's avatarArkadiusz Hiler <ahiler@codeweavers.com>
    Signed-off-by: 's avatarRémi Bernon <rbernon@codeweavers.com>
    Signed-off-by: 's avatarAlexandre Julliard <julliard@winehq.org>
    5cb70e73
device.c 22.1 KB