Commit 02a80554 authored by Marcus Meissner's avatar Marcus Meissner Committed by Alexandre Julliard

wininet: Move freeing netconn into create_netconn_socket (Coverity).

parent c29c639c
......@@ -655,7 +655,6 @@ static DWORD create_netconn_socket(server_t *server, netconn_t *netconn, DWORD t
if (!res)
{
closesocket(netconn->socketFD);
heap_free(netconn);
return ERROR_INTERNET_CANNOT_CONNECT;
}
else if (res > 0)
......@@ -674,10 +673,8 @@ static DWORD create_netconn_socket(server_t *server, netconn_t *netconn, DWORD t
ioctlsocket(netconn->socketFD, FIONBIO, &flag);
}
}
if(result == -1) {
heap_free(netconn);
if(result == -1)
return sock_get_error(errno);
}
#ifdef TCP_NODELAY
flag = 1;
......@@ -717,9 +714,13 @@ DWORD create_netconn(BOOL useSSL, server_t *server, DWORD security_flags, BOOL m
list_init(&netconn->pool_entry);
result = create_netconn_socket(server, netconn, timeout);
if (result != ERROR_SUCCESS) {
heap_free(netconn);
return result;
}
server_addref(server);
netconn->server = server;
*ret = netconn;
return result;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment