ole32: Fix memory leak on error path in composite_get_(left|right)most (Coverity).

02b226f7 · Alex Henrie · Alexandre Julliard · 9dcd2b3c · 02b226f7
Commit 02b226f7 authored Nov 16, 2022 by Alex Henrie Committed by Alexandre Julliard Nov 17, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 0 deletions

compositemoniker.c dlls/ole32/compositemoniker.c +2 -0

No files found.
--- a/dlls/ole32/compositemoniker.c
+++ b/dlls/ole32/compositemoniker.c
@@ -1627,6 +1627,7 @@ static HRESULT composite_get_rightmost(CompositeMonikerImpl *composite, IMoniker
    if (!(node = moniker_tree_get_rightmost(root)))
    {
        WARN("Couldn't get right most component.\n");
+        moniker_tree_release(root);
        return E_FAIL;
    }

@@ -1663,6 +1664,7 @@ static HRESULT composite_get_leftmost(CompositeMonikerImpl *composite, IMoniker 
    if (!(node = moniker_tree_get_leftmost(root)))
    {
        WARN("Couldn't get left most component.\n");
+        moniker_tree_release(root);
        return E_FAIL;
    }