wldap32: Free resource in error case and return error code (Coverity).

Signed-off-by: Fabian Maurer <dark.shadow4@web.de>

wldap32: Free resource in error case and return error code (Coverity).
0408d3a8 · Fabian Maurer · Alexandre Julliard · 4a8b12a1 · 0408d3a8
Commit 0408d3a8 authored Dec 11, 2022 by Fabian Maurer Committed by Alexandre Julliard Jan 24, 2023
Hide whitespace changes
Inline Side-by-side

Showing with 9 additions and 3 deletions

misc.c dlls/wldap32/misc.c +9 -3

No files found.
--- a/dlls/wldap32/misc.c
+++ b/dlls/wldap32/misc.c
@@ -413,12 +413,18 @@ ULONG CDECL WLDAP32_ldap_result( LDAP *ld, ULONG msgid, ULONG all, struct l_time

        ret = ldap_result( CTX(ld), msgid, all, timeout ? &timeval : NULL, &msgU );
    }
-    if (msgU && (msg = calloc( 1, sizeof(*msg) )))
+
+    if (!msgU)
+        return ret;
+
+    if (!(msg = calloc( 1, sizeof(*msg) )))
    {
-        MSG(msg) = msgU;
-        *res = msg;
+        free( msgU );
+        return WLDAP32_LDAP_NO_MEMORY;
    }

+    MSG(msg) = msgU;
+    *res = msg;
    return ret;
 }