Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-cw
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-cw
Commits
071f38b1
Commit
071f38b1
authored
Dec 19, 2022
by
Santino Mazza
Committed by
Alexandre Julliard
Jan 26, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
mshtml: Use This->node for HTMLDocument_get_all.
parent
d8030d15
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
32 deletions
+6
-32
htmldoc.c
dlls/mshtml/htmldoc.c
+2
-28
dom.c
dlls/mshtml/tests/dom.c
+4
-4
No files found.
dlls/mshtml/htmldoc.c
View file @
071f38b1
...
...
@@ -487,37 +487,11 @@ static HRESULT WINAPI HTMLDocument_get_Script(IHTMLDocument2 *iface, IDispatch *
static
HRESULT
WINAPI
HTMLDocument_get_all
(
IHTMLDocument2
*
iface
,
IHTMLElementCollection
**
p
)
{
HTMLDocumentNode
*
This
=
impl_from_IHTMLDocument2
(
iface
);
nsIDOMElement
*
nselem
=
NULL
;
HTMLDOMNode
*
node
;
nsresult
nsres
;
HRESULT
hres
;
TRACE
(
"(%p)->(%p)
\n
"
,
This
,
p
);
*
p
=
create_all_collection
(
&
This
->
node
,
FALSE
);
if
(
!
This
->
dom_document
)
{
WARN
(
"NULL dom_document
\n
"
);
return
E_UNEXPECTED
;
}
nsres
=
nsIDOMDocument_GetDocumentElement
(
This
->
dom_document
,
&
nselem
);
if
(
NS_FAILED
(
nsres
))
{
ERR
(
"GetDocumentElement failed: %08lx
\n
"
,
nsres
);
return
E_FAIL
;
}
if
(
!
nselem
)
{
*
p
=
NULL
;
return
S_OK
;
}
hres
=
get_node
((
nsIDOMNode
*
)
nselem
,
TRUE
,
&
node
);
nsIDOMElement_Release
(
nselem
);
if
(
FAILED
(
hres
))
return
hres
;
*
p
=
create_all_collection
(
node
,
TRUE
);
node_release
(
node
);
return
hres
;
return
S_OK
;
}
static
HRESULT
WINAPI
HTMLDocument_get_body
(
IHTMLDocument2
*
iface
,
IHTMLElement
**
p
)
...
...
dlls/mshtml/tests/dom.c
View file @
071f38b1
...
...
@@ -11026,8 +11026,8 @@ static void test_docfrag(IHTMLDocument2 *doc)
col
=
NULL
;
hres
=
IHTMLDocument2_get_all
(
frag
,
&
col
);
todo_wine
ok
(
hres
==
S_OK
,
"get_all failed: %08lx
\n
"
,
hres
);
todo_wine
ok
(
col
!=
NULL
,
"got null elements collection
\n
"
);
ok
(
hres
==
S_OK
,
"get_all failed: %08lx
\n
"
,
hres
);
ok
(
col
!=
NULL
,
"got null elements collection
\n
"
);
if
(
col
)
{
test_elem_collection
((
IUnknown
*
)
col
,
empty_types
,
ARRAY_SIZE
(
empty_types
));
IHTMLElementCollection_Release
(
col
);
...
...
@@ -11090,8 +11090,8 @@ static void test_docfrag(IHTMLDocument2 *doc)
col
=
NULL
;
hres
=
IHTMLDocument2_get_all
(
frag
,
&
col
);
todo_wine
ok
(
hres
==
S_OK
,
"get_all failed: %08lx
\n
"
,
hres
);
todo_wine
ok
(
col
!=
NULL
,
"got null elements collection
\n
"
);
ok
(
hres
==
S_OK
,
"get_all failed: %08lx
\n
"
,
hres
);
ok
(
col
!=
NULL
,
"got null elements collection
\n
"
);
if
(
col
)
{
test_elem_collection
((
IUnknown
*
)
col
,
frag_types
,
ARRAY_SIZE
(
frag_types
));
IHTMLElementCollection_Release
(
col
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment