Commit 0b3b3511 authored by Paul Vriens's avatar Paul Vriens Committed by Alexandre Julliard

Print retval in decimal to avoid confusion.

NT4 fails with ERROR_INVALID_TARGET_HANDLE instead of ERROR_REDIR_PAUSED. Use some correct messages on error. Extra tracing.
parent e64b8753
...@@ -181,19 +181,19 @@ void test_rename() ...@@ -181,19 +181,19 @@ void test_rename()
set_curr_dir_path(to, "test4.txt\0"); set_curr_dir_path(to, "test4.txt\0");
ok(SHFileOperationA(&shfo), "File is not renamed moving to other directory " ok(SHFileOperationA(&shfo), "File is not renamed moving to other directory "
"when specifying directory name only\n"); "when specifying directory name only\n");
ok(file_exists(".\\test1.txt"), "The file is not removed\n"); ok(file_exists(".\\test1.txt"), "The file is removed\n");
set_curr_dir_path(from, "test3.txt\0"); set_curr_dir_path(from, "test3.txt\0");
set_curr_dir_path(to, "test4.txt\\test1.txt\0"); set_curr_dir_path(to, "test4.txt\\test1.txt\0");
ok(!SHFileOperationA(&shfo), "File is renamed moving to other directory\n"); ok(!SHFileOperationA(&shfo), "File is renamed moving to other directory\n");
ok(file_exists(".\\test4.txt\\test1.txt"), "The file is renamed\n"); ok(file_exists(".\\test4.txt\\test1.txt"), "The file is not renamed\n");
set_curr_dir_path(from, "test1.txt\0test2.txt\0test4.txt\0"); set_curr_dir_path(from, "test1.txt\0test2.txt\0test4.txt\0");
set_curr_dir_path(to, "test6.txt\0test7.txt\0test8.txt\0"); set_curr_dir_path(to, "test6.txt\0test7.txt\0test8.txt\0");
retval = SHFileOperationA(&shfo); /* W98 returns 0, W2K and newer returns ERROR_GEN_FAILURE, both do nothing */ retval = SHFileOperationA(&shfo); /* W98 returns 0, W2K and newer returns ERROR_GEN_FAILURE, both do nothing */
ok(!retval || retval == ERROR_GEN_FAILURE || retval == ERROR_REDIR_PAUSED, ok(!retval || retval == ERROR_GEN_FAILURE || retval == ERROR_INVALID_TARGET_HANDLE,
"Can't rename many files, retval = %lx\n", retval); "Can't rename many files, retval = %ld\n", retval);
ok(file_exists(".\\test1.txt"), "The file is not renamed - many files are specified\n"); ok(file_exists(".\\test1.txt"), "The file is renamed - many files are specified\n");
memcpy(&shfo2, &shfo, sizeof(SHFILEOPSTRUCTA)); memcpy(&shfo2, &shfo, sizeof(SHFILEOPSTRUCTA));
shfo2.fFlags |= FOF_MULTIDESTFILES; shfo2.fFlags |= FOF_MULTIDESTFILES;
...@@ -201,27 +201,33 @@ void test_rename() ...@@ -201,27 +201,33 @@ void test_rename()
set_curr_dir_path(from, "test1.txt\0test2.txt\0test4.txt\0"); set_curr_dir_path(from, "test1.txt\0test2.txt\0test4.txt\0");
set_curr_dir_path(to, "test6.txt\0test7.txt\0test8.txt\0"); set_curr_dir_path(to, "test6.txt\0test7.txt\0test8.txt\0");
retval = SHFileOperationA(&shfo2); /* W98 returns 0, W2K and newer returns ERROR_GEN_FAILURE, both do nothing */ retval = SHFileOperationA(&shfo2); /* W98 returns 0, W2K and newer returns ERROR_GEN_FAILURE, both do nothing */
ok(!retval || retval == ERROR_GEN_FAILURE || retval == ERROR_REDIR_PAUSED, ok(!retval || retval == ERROR_GEN_FAILURE || retval == ERROR_INVALID_TARGET_HANDLE,
"Can't rename many files, retval = %lx\n", retval); "Can't rename many files, retval = %ld\n", retval);
ok(file_exists(".\\test1.txt"), "The file is not renamed - many files are specified\n"); ok(file_exists(".\\test1.txt"), "The file is not renamed - many files are specified\n");
set_curr_dir_path(from, "test1.txt\0"); set_curr_dir_path(from, "test1.txt\0");
set_curr_dir_path(to, "test6.txt\0"); set_curr_dir_path(to, "test6.txt\0");
ok(!SHFileOperationA(&shfo), "Rename file\n"); retval = SHFileOperationA(&shfo);
ok(!file_exists(".\\test1.txt"), "The file is renamed\n"); ok(!retval, "Rename file failed, retval = %ld\n", retval);
ok(file_exists(".\\test6.txt"), "The file is renamed\n"); ok(!file_exists(".\\test1.txt"), "The file is not renamed\n");
ok(file_exists(".\\test6.txt"), "The file is not renamed\n");
set_curr_dir_path(from, "test6.txt\0"); set_curr_dir_path(from, "test6.txt\0");
set_curr_dir_path(to, "test1.txt\0"); set_curr_dir_path(to, "test1.txt\0");
ok(!SHFileOperationA(&shfo), "Rename file back\n"); retval = SHFileOperationA(&shfo);
ok(!retval, "Rename file back failed, retval = %ld\n", retval);
set_curr_dir_path(from, "test4.txt\0"); set_curr_dir_path(from, "test4.txt\0");
set_curr_dir_path(to, "test6.txt\0"); set_curr_dir_path(to, "test6.txt\0");
ok(!SHFileOperationA(&shfo), "Rename dir\n"); retval = SHFileOperationA(&shfo);
ok(!file_exists(".\\test4.txt"), "The dir is renamed\n"); ok(!retval, "Rename dir failed, retval = %ld\n", retval);
ok(file_exists(".\\test6.txt"), "The dir is renamed\n"); ok(!file_exists(".\\test4.txt"), "The dir is not renamed\n");
ok(file_exists(".\\test6.txt"), "The dir is not renamed\n");
set_curr_dir_path(from, "test6.txt\0"); set_curr_dir_path(from, "test6.txt\0");
set_curr_dir_path(to, "test4.txt\0"); set_curr_dir_path(to, "test4.txt\0");
ok(!SHFileOperationA(&shfo), "Rename dir back\n"); retval = SHFileOperationA(&shfo);
ok(!retval, "Rename dir back failed, retval = %ld\n", retval);
} }
/* tests the FO_COPY action */ /* tests the FO_COPY action */
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment