msctf: Check TF_GetThreadMgr error in DocumentMgr_Destructor.

Thread manager could be already destroyed when calling DocumentMgr_Destructor. This removes the error dialog when closing Unreal Engine 4 games. Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

msctf: Check TF_GetThreadMgr error in DocumentMgr_Destructor.
0bebbbaa · Zhiyi Zhang · Alexandre Julliard · 5fb8e3ed · 0bebbbaa
Commit 0bebbbaa authored Aug 27, 2019 by Zhiyi Zhang Committed by Alexandre Julliard Aug 27, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 2 deletions

documentmgr.c dlls/msctf/documentmgr.c +6 -2

No files found.
--- a/dlls/msctf/documentmgr.c
+++ b/dlls/msctf/documentmgr.c
@@ -77,11 +77,15 @@ static inline EnumTfContext *impl_from_IEnumTfContexts(IEnumTfContexts *iface)

 static void DocumentMgr_Destructor(DocumentMgr *This)
 {
-    ITfThreadMgr *tm;
+    ITfThreadMgr *tm = NULL;
    TRACE("destroying %p\n", This);

    TF_GetThreadMgr(&tm);
-    ThreadMgr_OnDocumentMgrDestruction(tm, &This->ITfDocumentMgr_iface);
+    if (tm)
+    {
+        ThreadMgr_OnDocumentMgrDestruction(tm, &This->ITfDocumentMgr_iface);
+        ITfThreadMgr_Release(tm);
+    }

    if (This->contextStack[0])
        ITfContext_Release(This->contextStack[0]);