tasklist: Fix a possible buffer overrun (Coverity).

process_entry->szExeFile has length of MAX_PATH but info->image_name only has 32.

tasklist: Fix a possible buffer overrun (Coverity).
1a6deb1c · Zhiyi Zhang · Alexandre Julliard · eeb1826c · 1a6deb1c
Commit 1a6deb1c authored Dec 02, 2023 by Zhiyi Zhang Committed by Alexandre Julliard Dec 04, 2023
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

tasklist.c programs/tasklist/tasklist.c +1 -1

No files found.
--- a/programs/tasklist/tasklist.c
+++ b/programs/tasklist/tasklist.c
@@ -176,7 +176,7 @@ static BOOL tasklist_get_process_info(const PROCESSENTRY32W *process_entry, stru
    info->pid_value = process_entry->th32ProcessID;
    info->memory_usage_value = memory_counters.WorkingSetSize / 1024;
    info->session_id_value = session_id;
-    wcscpy(info->image_name, process_entry->szExeFile);
+    lstrcpynW(info->image_name, process_entry->szExeFile, ARRAY_SIZE(info->image_name));
    swprintf(info->pid, ARRAY_SIZE(info->pid), L"%u", process_entry->th32ProcessID);
    wcscpy(info->session_name, session_id == 0 ? L"Services" : L"Console");
    swprintf(info->session_number, ARRAY_SIZE(info->session_number), L"%u", session_id);