winegstreamer: Avoid releasing wg_allocator memory samples twice.

When the sample size is too small, we were releasing it from the memory, but kept the next_sample pointer set. Later, when the transform removes the sample from the allocator, its refcount was decremented one more time, effectively leaking the sample.

winegstreamer: Avoid releasing wg_allocator memory samples twice.
1b5ddc1e · Rémi Bernon · Alexandre Julliard · 762dda38 · 1b5ddc1e
Commit 1b5ddc1e authored Jun 25, 2023 by Rémi Bernon Committed by Alexandre Julliard Jul 31, 2023
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 3 deletions

wg_allocator.c dlls/winegstreamer/wg_allocator.c +3 -3

No files found.
--- a/dlls/winegstreamer/wg_allocator.c
+++ b/dlls/winegstreamer/wg_allocator.c
@@ -196,9 +196,9 @@ static GstMemory *wg_allocator_alloc(GstAllocator *gst_allocator, gsize size,
    pthread_mutex_lock(&allocator->mutex);
    memory->sample = allocator->next_sample;
-    if (memory->sample && memory->sample->max_size >= size)
+    allocator->next_sample = NULL;
-        allocator->next_sample = NULL;
-    else
+    if (memory->sample && memory->sample->max_size < size)
        release_memory_sample(allocator, memory, true);
    list_add_tail(&allocator->memory_list, &memory->entry);