Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-cw
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-cw
Commits
1d57a31d
Commit
1d57a31d
authored
May 21, 2009
by
Vincent Povirk
Committed by
Alexandre Julliard
May 22, 2009
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
shell32: Fail properly when no pidl is passed to SHCreateShellItem.
parent
026c37e7
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
2 deletions
+6
-2
shellitem.c
dlls/shell32/shellitem.c
+5
-1
shlfolder.c
dlls/shell32/tests/shlfolder.c
+1
-1
No files found.
dlls/shell32/shellitem.c
View file @
1d57a31d
...
...
@@ -276,7 +276,11 @@ HRESULT WINAPI SHCreateShellItem(LPCITEMIDLIST pidlParent,
TRACE
(
"(%p,%p,%p,%p)
\n
"
,
pidlParent
,
psfParent
,
pidl
,
ppsi
);
if
(
!
pidlParent
&&
!
psfParent
&&
pidl
)
if
(
!
pidl
)
{
return
E_INVALIDARG
;
}
else
if
(
!
pidlParent
&&
!
psfParent
)
{
new_pidl
=
ILClone
(
pidl
);
if
(
!
new_pidl
)
...
...
dlls/shell32/tests/shlfolder.c
View file @
1d57a31d
...
...
@@ -1783,7 +1783,7 @@ static void test_SHCreateShellItem(void)
pidl_abstestfile
=
pILCombine
(
pidl_cwd
,
pidl_testfile
);
ret
=
pSHCreateShellItem
(
NULL
,
NULL
,
NULL
,
&
shellitem
);
todo_wine
ok
(
ret
==
E_INVALIDARG
,
"SHCreateShellItem returned %x
\n
"
,
ret
);
ok
(
ret
==
E_INVALIDARG
,
"SHCreateShellItem returned %x
\n
"
,
ret
);
if
(
0
)
/* crashes on Windows XP */
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment