msi: Only copy the resulting string if the RegistryValue call succeeded.

1fed032a · James Hawkins · Alexandre Julliard · 1ed12b76 · 1fed032a
Commit 1fed032a authored Jul 08, 2008 by James Hawkins Committed by Alexandre Julliard Jul 09, 2008
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

automation.c dlls/msi/tests/automation.c +1 -1

No files found.
--- a/dlls/msi/tests/automation.c
+++ b/dlls/msi/tests/automation.c
@@ -804,7 +804,7 @@ static HRESULT Installer_RegistryValueI(HKEY hkey, LPCWSTR szKey, int iValue, LP
    V_I4(&vararg) = iValue;

    hr = Installer_RegistryValue(hkey, szKey, vararg, &varresult, vtResult);
-    if (vtResult == VT_BSTR) lstrcpyW(szString, V_BSTR(&varresult));
+    if (SUCCEEDED(hr) && vtResult == VT_BSTR) lstrcpyW(szString, V_BSTR(&varresult));
    VariantClear(&varresult);
    return hr;
 }