dnsapi: Return a double-null-terminated string from DnsQueryConfig(DnsConfigSearchList).

DNS_TEXT_DATA contains pointers and is thus not WoW64 compatible. Since the API is internal to Wine, use a simpler format instead of fixing our WoW64 translation. The problem was found by Brendan Shanks; this solution was suggested by Hans Leidekker.

dnsapi: Return a double-null-terminated string from DnsQueryConfig(DnsConfigSearchList).
23d85e6e · Zebediah Figura · Alexandre Julliard · 91083d45 · 23d85e6e · 23d85e6e
Commit 23d85e6e authored Jun 24, 2022 by Zebediah Figura Committed by Alexandre Julliard Jun 27, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 12 additions and 17 deletions

dnsapi.h dlls/dnsapi/dnsapi.h +1 -1

libresolv.c dlls/dnsapi/libresolv.c +8 -13

iphlpapi_main.c dlls/iphlpapi/iphlpapi_main.c +3 -3

No files found.
--- a/dlls/dnsapi/dnsapi.h
+++ b/dlls/dnsapi/dnsapi.h
@@ -128,7 +128,7 @@ extern const char *debugstr_type( unsigned short ) DECLSPEC_HIDDEN;
 struct get_searchlist_params
 {
-    DNS_TXT_DATAW   *list;
+    WCHAR           *list;
    DWORD           *len;
 };

--- a/dlls/dnsapi/libresolv.c
+++ b/dlls/dnsapi/libresolv.c
@@ -125,16 +125,15 @@ static DNS_STATUS map_h_errno( int error )
 static NTSTATUS resolv_get_searchlist( void *args )
 {
    const struct get_searchlist_params *params = args;
-    DNS_TXT_DATAW *list = params->list;
+    WCHAR *list = params->list;
-    DWORD i, needed, str_needed = 0;
+    DWORD i, needed = 0;
    WCHAR *ptr, *end;
    init_resolver();
    for (i = 0; i < MAXDNSRCH + 1 && _res.dnsrch[i]; i++)
-        str_needed += (strlen(_res.dnsrch[i]) + 1) * sizeof(WCHAR);
+        needed += (strlen(_res.dnsrch[i]) + 1) * sizeof(WCHAR);
+    needed += sizeof(WCHAR); /* null terminator */
-    needed = FIELD_OFFSET(DNS_TXT_DATAW, pStringArray[i]) + str_needed;
    if (!list || *params->len < needed)
    {
@@ -143,16 +142,12 @@ static NTSTATUS resolv_get_searchlist( void *args )
    }
    *params->len = needed;
-    list->dwStringCount = i;
-    ptr = (WCHAR *)(list->pStringArray + i);
+    ptr = list;
-    end = ptr + str_needed / sizeof(WCHAR);
+    end = ptr + needed / sizeof(WCHAR);
    for (i = 0; i < MAXDNSRCH + 1 && _res.dnsrch[i]; i++)
-    {
+        ptr += ntdll_umbstowcs( _res.dnsrch[i], strlen(_res.dnsrch[i]) + 1, ptr, end - ptr );
-        list->pStringArray[i] = ptr;
+    *ptr = 0; /* null terminator */
-        ptr += ntdll_umbstowcs( _res.dnsrch[i], strlen(_res.dnsrch[i]) + 1,
-                                list->pStringArray[i], end - ptr );
-    }
    return ERROR_SUCCESS;
 }

--- a/dlls/iphlpapi/iphlpapi_main.c
+++ b/dlls/iphlpapi/iphlpapi_main.c
@@ -1138,7 +1138,7 @@ static DWORD dns_info_alloc( IP_ADAPTER_ADDRESSES *aa, ULONG family, ULONG flags
    DWORD err, i, size, attempt, sockaddr_len;
    WCHAR name[MAX_ADAPTER_NAME_LENGTH + 1];
    DNS_ADDR_ARRAY *servers;
-    DNS_TXT_DATAW *search;
+    WCHAR *search;
    while (aa)
    {
@@ -1192,9 +1192,9 @@ static DWORD dns_info_alloc( IP_ADAPTER_ADDRESSES *aa, ULONG family, ULONG flags
            (search = heap_alloc( size )))
        {
            if (!DnsQueryConfig( DnsConfigSearchList, 0, name, NULL, search, &size ) &&
-                search->dwStringCount && wcslen( search->pStringArray[0] ) < MAX_DNS_SUFFIX_STRING_LENGTH)
+                search[0] && wcslen( search ) < MAX_DNS_SUFFIX_STRING_LENGTH)
            {
-                wcscpy( aa->DnsSuffix, search->pStringArray[0] );
+                wcscpy( aa->DnsSuffix, search );
            }
            heap_free( search );
        }