Commit 26541a00 authored by Alexandre Julliard's avatar Alexandre Julliard

Authors: Mike Hearn <mh@codeweavers.com>, Robert Shearman <rob@codeweavers.com>

Add a comment on the SendReceive behaviour. Improve two others.
parent 4a132c4f
...@@ -85,10 +85,11 @@ typedef struct _wine_rpc_request { ...@@ -85,10 +85,11 @@ typedef struct _wine_rpc_request {
static wine_rpc_request **reqs = NULL; static wine_rpc_request **reqs = NULL;
static int nrofreqs = 0; static int nrofreqs = 0;
/* This pipe is _thread_ based */ /* This pipe is _thread_ based, each thread which talks to a remote
* apartment (mid) has its own pipe */
typedef struct _wine_pipe { typedef struct _wine_pipe {
wine_marshal_id mid; /* target mid */ wine_marshal_id mid; /* target mid */
DWORD tid; /* thread in which we execute */ DWORD tid; /* thread which owns this outgoing pipe */
HANDLE hPipe; HANDLE hPipe;
int pending; int pending;
...@@ -298,7 +299,7 @@ PipeBuf_GetBuffer( ...@@ -298,7 +299,7 @@ PipeBuf_GetBuffer(
) { ) {
/*ICOM_THIS(PipeBuf,iface);*/ /*ICOM_THIS(PipeBuf,iface);*/
TRACE("(%p,%s), slightly wrong.\n",msg,debugstr_guid(riid)); TRACE("(%p,%s)\n",msg,debugstr_guid(riid));
/* probably reuses IID in real. */ /* probably reuses IID in real. */
if (msg->cbBuffer && (msg->Buffer == NULL)) if (msg->cbBuffer && (msg->Buffer == NULL))
msg->Buffer = HeapAlloc(GetProcessHeap(),0,msg->cbBuffer); msg->Buffer = HeapAlloc(GetProcessHeap(),0,msg->cbBuffer);
...@@ -366,8 +367,9 @@ RPC_QueueRequestAndWait(wine_rpc_request *req) { ...@@ -366,8 +367,9 @@ RPC_QueueRequestAndWait(wine_rpc_request *req) {
hres = _xwrite(req->hPipe,req->Buffer,req->reqh.cbBuffer); hres = _xwrite(req->hPipe,req->Buffer,req->reqh.cbBuffer);
if (hres) return hres; if (hres) return hres;
/* This loop is about allowing re-entrancy. While waiting for the
* response to one RPC we may receive a request starting another. */
while (1) { while (1) {
/*WaitForSingleObject(hRpcChanged,INFINITE);*/
hres = _read_one(xpipe); hres = _read_one(xpipe);
if (hres) break; if (hres) break;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment