dsound: Use malloc and free instead of _recalloc.

The memory is completely overwritten a few lines later, so there is no reason to preserve its original contents. Furthermore, _recalloc will not be available if this DLL switches from ucrtbase to msvcrt, and the code as written would leak memory if _recalloc failed.

dsound: Use malloc and free instead of _recalloc.
269ce609 · Alex Henrie · Alexandre Julliard · d5988259 · 269ce609
Commit 269ce609 authored Sep 16, 2023 by Alex Henrie Committed by Alexandre Julliard Sep 20, 2023
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

capture.c dlls/dsound/capture.c +2 -1

No files found.
--- a/dlls/dsound/capture.c
+++ b/dlls/dsound/capture.c
@@ -178,7 +178,8 @@ static HRESULT WINAPI IDirectSoundNotifyImpl_SetNotificationPositions(IDirectSou
    if (howmuch > 0) {
 	/* Make an internal copy of the caller-supplied array.
 	 * Replace the existing copy if one is already present. */
-        This->notifies = _recalloc(This->notifies, howmuch, sizeof(DSBPOSITIONNOTIFY));
+        free(This->notifies);
+        This->notifies = malloc(howmuch * sizeof(DSBPOSITIONNOTIFY));
        if (!This->notifies) {
 	    WARN("out of memory\n");
 	    return DSERR_OUTOFMEMORY;