mfplay: Prevent usage of uninitialized pointer in error case (Coverity).

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

mfplay: Prevent usage of uninitialized pointer in error case (Coverity).
312e0d51 · Fabian Maurer · Alexandre Julliard · b67d66f5 · 312e0d51
Commit 312e0d51 authored Apr 27, 2022 by Fabian Maurer Committed by Alexandre Julliard Apr 27, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

player.c dlls/mfplay/player.c +2 -1

No files found.
--- a/dlls/mfplay/player.c
+++ b/dlls/mfplay/player.c
@@ -1378,7 +1378,6 @@ static HRESULT media_item_create_sink_node(IUnknown *sink, IMFTopologyNode **nod

 static HRESULT media_item_create_topology(struct media_player *player, struct media_item *item, IMFTopology **out)
 {
-    IMFTopologyNode *src_node, *sink_node;
    BOOL selected, video_added = FALSE;
    IMFStreamDescriptor *sd;
    IMFTopology *topology;
@@ -1421,6 +1420,8 @@ static HRESULT media_item_create_topology(struct media_player *player, struct me

        if (sink)
        {
+            IMFTopologyNode *src_node = NULL, *sink_node = NULL;
+
            hr = media_item_create_source_node(item, sd, &src_node);
            if (SUCCEEDED(hr))
                hr = media_item_create_sink_node(sink, &sink_node);