ntdll: Potential buffer overwrite (Coverity).

33d4125a · Marcus Meissner · Alexandre Julliard · a57b06c5 · 33d4125a
Commit 33d4125a authored Apr 19, 2015 by Marcus Meissner Committed by Alexandre Julliard Apr 20, 2015
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 2 deletions

cdrom.c dlls/ntdll/cdrom.c +5 -2

No files found.
--- a/dlls/ntdll/cdrom.c
+++ b/dlls/ntdll/cdrom.c
@@ -3090,8 +3090,11 @@ NTSTATUS CDROM_DeviceIoControl(HANDLE hDevice,
        sz = sizeof(DVD_REGION);
        if (lpInBuffer != NULL || nInBufferSize != 0) status = STATUS_INVALID_PARAMETER;
        else if (nOutBufferSize < sz) status = STATUS_BUFFER_TOO_SMALL;
-        TRACE("doing DVD_Get_REGION\n");
-        status = DVD_GetRegion(fd, lpOutBuffer);
+        else
+        {
+            TRACE("doing DVD_Get_REGION\n");
+            status = DVD_GetRegion(fd, lpOutBuffer);
+        }
        break;
    case IOCTL_DVD_READ_STRUCTURE:
        sz = sizeof(DVD_LAYER_DESCRIPTOR);