wined3d: Always bind to GL_ELEMENT_ARRAY_BUFFER if the bind flags include…

wined3d: Always bind to GL_ELEMENT_ARRAY_BUFFER if the bind flags include WINED3D_BIND_INDEX_BUFFER. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53623

wined3d: Always bind to GL_ELEMENT_ARRAY_BUFFER if the bind flags include…
33d6900b · Zebediah Figura · Alexandre Julliard · 45b82311 · 33d6900b
Commit 33d6900b authored Dec 13, 2022 by Zebediah Figura Committed by Alexandre Julliard Dec 14, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

buffer.c dlls/wined3d/buffer.c +5 -1

No files found.
--- a/dlls/wined3d/buffer.c
+++ b/dlls/wined3d/buffer.c
@@ -141,7 +141,11 @@ GLenum wined3d_buffer_gl_binding_from_bind_flags(const struct wined3d_gl_info *g
    if (!bind_flags)
        return GL_PIXEL_UNPACK_BUFFER;
-    if (bind_flags == WINED3D_BIND_INDEX_BUFFER)
+    /* We must always return GL_ELEMENT_ARRAY_BUFFER here;
+     * wined3d_device_gl_create_bo() checks the GL binding to see whether we
+     * can suballocate, and we cannot suballocate if this BO might be used for
+     * an index buffer. */
+    if (bind_flags & WINED3D_BIND_INDEX_BUFFER)
        return GL_ELEMENT_ARRAY_BUFFER;
    if (bind_flags & (WINED3D_BIND_SHADER_RESOURCE | WINED3D_BIND_UNORDERED_ACCESS)