Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-cw
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-cw
Commits
36117911
Commit
36117911
authored
Jun 13, 2010
by
Nikolay Sivov
Committed by
Alexandre Julliard
Jun 14, 2010
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
msxml3: Avoid SysStringLen() testing for an empty string in ::createNode().
parent
43d9c9bb
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
12 additions
and
1 deletion
+12
-1
domdoc.c
dlls/msxml3/domdoc.c
+1
-1
domdoc.c
dlls/msxml3/tests/domdoc.c
+11
-0
No files found.
dlls/msxml3/domdoc.c
View file @
36117911
...
...
@@ -1368,7 +1368,7 @@ static HRESULT WINAPI domdoc_createNode(
case
NODE_ATTRIBUTE
:
case
NODE_ENTITY_REFERENCE
:
case
NODE_PROCESSING_INSTRUCTION
:
if
(
!
name
||
SysStringLen
(
name
)
==
0
)
return
E_FAIL
;
if
(
!
name
||
*
name
==
0
)
return
E_FAIL
;
default:
break
;
}
...
...
dlls/msxml3/tests/domdoc.c
View file @
36117911
...
...
@@ -1988,6 +1988,17 @@ static void test_create(void)
if
(
SUCCEEDED
(
r
)
)
IXMLDOMNode_Release
(
node
);
SysFreeString
(
str
);
/* a name is required for attribute, try a BSTR with first null wchar */
V_VT
(
&
var
)
=
VT_I1
;
V_I1
(
&
var
)
=
NODE_ATTRIBUTE
;
str
=
SysAllocString
(
szstr1
);
str
[
0
]
=
0
;
node
=
(
IXMLDOMNode
*
)
0x1
;
r
=
IXMLDOMDocument_createNode
(
doc
,
var
,
str
,
NULL
,
&
node
);
ok
(
r
==
E_FAIL
,
"returns %08x
\n
"
,
r
);
ok
(
node
==
(
void
*
)
0x1
,
"expected same ptr, got %p
\n
"
,
node
);
SysFreeString
(
str
);
/* NODE_PROCESSING_INSTRUCTION */
V_VT
(
&
var
)
=
VT_I1
;
V_I1
(
&
var
)
=
NODE_PROCESSING_INSTRUCTION
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment