msv1_0: Avoid double free when SpAcceptLsaModeContext fails.

And a previously created context is passed, which may later be destroyed on its own, causing a double free.

msv1_0: Avoid double free when SpAcceptLsaModeContext fails.
3a143c09 · Rémi Bernon · Alexandre Julliard · f221465a · 3a143c09
Commit 3a143c09 authored Jan 12, 2023 by Rémi Bernon Committed by Alexandre Julliard Jan 13, 2023
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

main.c dlls/msv1_0/main.c +1 -1

No files found.
--- a/dlls/msv1_0/main.c
+++ b/dlls/msv1_0/main.c
@@ -1078,7 +1078,7 @@ static NTSTATUS NTAPI ntlm_SpAcceptLsaModeContext( LSA_SEC_HANDLE cred_handle, L
    }

 done:
-    if (status != SEC_E_OK && status != SEC_I_CONTINUE_NEEDED)
+    if (status != SEC_E_OK && status != SEC_I_CONTINUE_NEEDED && !ctx_handle)
    {
        ntlm_cleanup( ctx );
        free( ctx );