Skip to content

W
wine-cw
Commit 42d4f301 authored by Francois Gouget's avatar Francois Gouget Committed by Alexandre Julliard
Browse files
Options

Whenever we do an strncpy we should make sure we put a '\0' at the end

of the buffer.
parent f4077e66
Hide whitespace changes
Inline Side-by-side
Showing with 4 additions and 0 deletions
dlls/comctl32/listview.c
View file @ 42d4f301
......@@ -3609,10 +3609,12 @@ static LRESULT LISTVIEW_GetItemA(HWND hwnd, LPLVITEMA lpLVItem)
Str_SetPtrA(&lpItem->pszText, dispInfo.item.pszText);
}
strncpy(lpLVItem->pszText, dispInfo.item.pszText, lpLVItem->cchTextMax);
lpLVItem->pszText[lpLVItem->cchTextMax-1]='\0';
}
else if (lpLVItem->mask & LVIF_TEXT)
{
strncpy(lpLVItem->pszText, lpItem->pszText, lpLVItem->cchTextMax);
lpLVItem->pszText[lpLVItem->cchTextMax-1]='\0';
}
if (dispInfo.item.mask & LVIF_STATE)
......@@ -3704,10 +3706,12 @@ static LRESULT LISTVIEW_GetItemA(HWND hwnd, LPLVITEMA lpLVItem)
Str_SetPtrA(&lpSubItem->pszText, dispInfo.item.pszText);
}
strncpy(lpLVItem->pszText, dispInfo.item.pszText, lpLVItem->cchTextMax);
lpLVItem->pszText[lpLVItem->cchTextMax-1]='\0';
}
else if (lpLVItem->mask & LVIF_TEXT)
{
strncpy(lpLVItem->pszText, lpSubItem->pszText, lpLVItem->cchTextMax);
lpLVItem->pszText[lpLVItem->cchTextMax-1]='\0';
}
}
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment