services: Don't double release process in service_start.

Fixes a crash while running ntoskrnl tests. Signed-off-by: Piotr Caban <piotr@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

services: Don't double release process in service_start.
49638070 · Piotr Caban · Alexandre Julliard · 294cfaf0 · 49638070
Commit 49638070 authored May 27, 2019 by Piotr Caban Committed by Alexandre Julliard May 27, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 4 deletions

services.c programs/services/services.c +7 -4

No files found.
--- a/programs/services/services.c
+++ b/programs/services/services.c
@@ -1069,10 +1069,13 @@ DWORD service_start(struct service_entry *service, DWORD service_argc, LPCWSTR *
        if (err != ERROR_SUCCESS)
        {
            service_lock(service);
-            service->status.dwCurrentState = SERVICE_STOPPED;
+            if (service->process)
-            service->process = NULL;
+            {
-            if (!--process->use_count) process_terminate(process);
+                service->status.dwCurrentState = SERVICE_STOPPED;
-            release_process(process);
+                service->process = NULL;
+                if (!--process->use_count) process_terminate(process);
+                release_process(process);
+            }
            service_unlock(service);
        }