Skip to content

W
wine-cw
Commit 4b317fde authored by Nikolay Sivov's avatar Nikolay Sivov Committed by Alexandre Julliard
Browse files
Options

shell32: Fix a cloned PIDL leak (Valgrind).

parent 38a99502
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 3 deletions
dlls/shell32/shfldr_unixfs.c
View file @ 4b317fde
...@@ -1022,7 +1022,7 @@ static HRESULT WINAPI UnixFolder_IShellFolder2_CompareIDs(IShellFolder2* iface, ...@@ -1022,7 +1022,7 @@ static HRESULT WINAPI UnixFolder_IShellFolder2_CompareIDs(IShellFolder2* iface,
{ {
BOOL isEmpty1, isEmpty2; BOOL isEmpty1, isEmpty2;
HRESULT hr = E_FAIL; HRESULT hr = E_FAIL;
LPITEMIDLIST firstpidl; LPCITEMIDLIST firstpidl;
IShellFolder2 *psf; IShellFolder2 *psf;
int compare; int compare;
...@@ -1055,7 +1055,7 @@ static HRESULT WINAPI UnixFolder_IShellFolder2_CompareIDs(IShellFolder2* iface, ...@@ -1055,7 +1055,7 @@ static HRESULT WINAPI UnixFolder_IShellFolder2_CompareIDs(IShellFolder2* iface,
else if (pidl1->mkid.cb > pidl2->mkid.cb) else if (pidl1->mkid.cb > pidl2->mkid.cb)
return MAKE_HRESULT(SEVERITY_SUCCESS, 0, (WORD)1); return MAKE_HRESULT(SEVERITY_SUCCESS, 0, (WORD)1);
firstpidl = ILCloneFirst(pidl1); firstpidl = pidl1;
pidl1 = ILGetNext(pidl1); pidl1 = ILGetNext(pidl1);
pidl2 = ILGetNext(pidl2); pidl2 = ILGetNext(pidl2);
...@@ -1073,7 +1073,6 @@ static HRESULT WINAPI UnixFolder_IShellFolder2_CompareIDs(IShellFolder2* iface, ...@@ -1073,7 +1073,6 @@ static HRESULT WINAPI UnixFolder_IShellFolder2_CompareIDs(IShellFolder2* iface,
IShellFolder2_Release(psf); IShellFolder2_Release(psf);
} }
ILFree(firstpidl);
return hr; return hr;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment