hidclass.sys: Prevent buffer overrun.

Signed-off-by: Aric Stewart <aric@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

hidclass.sys: Prevent buffer overrun.
5040b8d5 · Aric Stewart · Alexandre Julliard · b16fb118 · 5040b8d5
Commit 5040b8d5 authored Feb 06, 2019 by Aric Stewart Committed by Alexandre Julliard Feb 06, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 2 deletions

descriptor.c dlls/hidclass.sys/descriptor.c +1 -2

No files found.
--- a/dlls/hidclass.sys/descriptor.c
+++ b/dlls/hidclass.sys/descriptor.c
@@ -838,8 +838,7 @@ static WINE_HIDP_PREPARSED_DATA* build_PreparseData(
    if (features[0]->caps.ReportID != 0)
    {
        unsigned int *report_ids;
-        unsigned int cnt = max(i_count, o_count);
-        cnt = max(cnt, f_count);
+        unsigned int cnt = i_count + o_count + f_count;
        report_ids = HeapAlloc(GetProcessHeap(), 0 , sizeof(*report_ids) * cnt);

        if (i_count)