reg: Abort 'delete' operation when parsing command-line arguments that are not switches.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

reg: Abort 'delete' operation when parsing command-line arguments that are not switches.
51e83dec · Hugh McMaster · Alexandre Julliard · b2ead1ff · 51e83dec
Commit 51e83dec authored Apr 02, 2021 by Hugh McMaster Committed by Alexandre Julliard Apr 02, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 31 additions and 29 deletions

delete.c programs/reg/delete.c +31 -29

No files found.
--- a/programs/reg/delete.c
+++ b/programs/reg/delete.c
@@ -118,38 +118,40 @@ int reg_delete(int argc, WCHAR *argvW[])
    for (i = 3; i < argc; i++)
    {
-        if (argvW[i][0] == '/' || argvW[i][0] == '-')
+        WCHAR *str;
-        {
-            WCHAR *str = &argvW[i][1];
-            if (!lstrcmpiW(str, L"va"))
+        if (argvW[i][0] != '/' && argvW[i][0] != '-')
-            {
+            goto invalid;
-                if (value_all) goto invalid;
-                value_all = TRUE;
-                continue;
-            }
-            else if (!lstrcmpiW(str, L"ve"))
-            {
-                if (value_empty) goto invalid;
-                value_empty = TRUE;
-                continue;
-            }
-            else if (!str[0] || str[1])
-                goto invalid;
-            switch (towlower(*str))
+        str = &argvW[i][1];
-            {
-            case 'v':
+        if (!lstrcmpiW(str, L"va"))
-                if (value_name || !(value_name = argvW[++i]))
+        {
-                    goto invalid;
+            if (value_all) goto invalid;
-                break;
+            value_all = TRUE;
-            case 'f':
+            continue;
-                if (force) goto invalid;
+        }
-                force = TRUE;
+        else if (!lstrcmpiW(str, L"ve"))
-                break;
+        {
-            default:
+            if (value_empty) goto invalid;
+            value_empty = TRUE;
+            continue;
+        }
+        else if (!str[0] || str[1])
+            goto invalid;
+        switch (towlower(*str))
+        {
+        case 'v':
+            if (value_name || !(value_name = argvW[++i]))
                goto invalid;
-            }
+            break;
+        case 'f':
+            if (force) goto invalid;
+            force = TRUE;
+            break;
+        default:
+            goto invalid;
        }
    }