rpcrt4: Fix memory leak in NdrFullPointerXlatFree.

First of all, the code was freeing the wrong pointer (i.e. the pointer supplied by the caller of one of the NdrFullPointer* functions, not the PFULL_PTR_TO_REFID_ELEMENT. Second, the code wasn't following the Next link to the next entry in the list.

rpcrt4: Fix memory leak in NdrFullPointerXlatFree.
52f08dd5 · Rob Shearman · Alexandre Julliard · 4b75f330 · 52f08dd5
Commit 52f08dd5 authored Jan 09, 2008 by Rob Shearman Committed by Alexandre Julliard Jan 09, 2008
Hide whitespace changes
Inline Side-by-side

Showing with 11 additions and 2 deletions

ndr_fullpointer.c dlls/rpcrt4/ndr_fullpointer.c +11 -2

No files found.
--- a/dlls/rpcrt4/ndr_fullpointer.c
+++ b/dlls/rpcrt4/ndr_fullpointer.c
@@ -68,8 +68,17 @@ void WINAPI NdrFullPointerXlatFree(PFULL_PTR_XLAT_TABLES pXlatTables)
    TRACE("(%p)\n", pXlatTables);

    /* free the entries in the table */
-    for (i = 0; i < pXlatTables->RefIdToPointer.NumberOfEntries; i++)
-        HeapFree(GetProcessHeap(), 0, pXlatTables->RefIdToPointer.XlatTable[i]);
+    for (i = 0; i < pXlatTables->PointerToRefId.NumberOfBuckets; i++)
+    {
+        PFULL_PTR_TO_REFID_ELEMENT XlatTableEntry;
+        for (XlatTableEntry = pXlatTables->PointerToRefId.XlatTable[i];
+            XlatTableEntry; )
+        {
+            PFULL_PTR_TO_REFID_ELEMENT Next = XlatTableEntry->Next;
+            HeapFree(GetProcessHeap(), 0, XlatTableEntry);
+            XlatTableEntry = Next;
+        }
+    }

    HeapFree(GetProcessHeap(), 0, pXlatTables->RefIdToPointer.XlatTable);
    HeapFree(GetProcessHeap(), 0, pXlatTables->RefIdToPointer.StateTable);