Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-cw
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-cw
Commits
557c3714
Commit
557c3714
authored
Nov 09, 2015
by
Dmitry Timoshkov
Committed by
Alexandre Julliard
Nov 09, 2015
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
taskschd/tests: Fix memory leaks (Valgrind).
Signed-off-by:
Dmitry Timoshkov
<
dmitry@baikal.ru
>
Signed-off-by:
Alexandre Julliard
<
julliard@winehq.org
>
parent
3b7cdc0b
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
17 additions
and
3 deletions
+17
-3
task.c
dlls/taskschd/task.c
+1
-1
scheduler.c
dlls/taskschd/tests/scheduler.c
+16
-2
No files found.
dlls/taskschd/task.c
View file @
557c3714
...
...
@@ -2611,8 +2611,8 @@ static HRESULT WINAPI TaskService_Connect(ITaskService *iface, VARIANT server, V
hr
=
RpcStringBindingComposeW
(
NULL
,
ncalrpc
,
NULL
,
NULL
,
NULL
,
&
binding_str
);
if
(
hr
!=
RPC_S_OK
)
return
hr
;
hr
=
RpcBindingFromStringBindingW
(
binding_str
,
&
rpc_handle
);
if
(
hr
!=
RPC_S_OK
)
return
hr
;
RpcStringFreeW
(
&
binding_str
);
if
(
hr
!=
RPC_S_OK
)
return
hr
;
/* Make sure that the connection works */
hr
=
SchRpcHighestVersion
(
&
task_svc
->
version
);
...
...
dlls/taskschd/tests/scheduler.c
View file @
557c3714
...
...
@@ -782,6 +782,7 @@ static void test_GetTask(void)
{
hr
=
ITaskFolder_DeleteTask
(
root
,
Wine_Task1
,
0
);
ok
(
hr
==
S_OK
,
"DeleteTask error %#x
\n
"
,
hr
);
IRegisteredTask_Release
(
task1
);
}
}
...
...
@@ -809,8 +810,10 @@ todo_wine
for
(
i
=
0
;
i
<
sizeof
(
open_existing_task
)
/
sizeof
(
open_existing_task
[
0
]);
i
++
)
{
hr
=
ITaskFolder_RegisterTask
(
root
,
Wine_Task1
,
xmlW
,
open_existing_task
[
i
].
flags
,
v_null
,
v_null
,
TASK_LOGON_NONE
,
v_null
,
&
task
1
);
hr
=
ITaskFolder_RegisterTask
(
root
,
Wine_Task1
,
xmlW
,
open_existing_task
[
i
].
flags
,
v_null
,
v_null
,
TASK_LOGON_NONE
,
v_null
,
&
task
2
);
ok
(
hr
==
open_existing_task
[
i
].
hr
,
"%d: expected %#x, got %#x
\n
"
,
i
,
open_existing_task
[
i
].
hr
,
hr
);
if
(
hr
==
S_OK
)
IRegisteredTask_Release
(
task2
);
}
hr
=
IRegisteredTask_get_Name
(
task1
,
NULL
);
...
...
@@ -944,6 +947,7 @@ todo_wine
ok
(
hr
==
S_OK
,
"get_Name error %#x
\n
"
,
hr
);
hr
=
IIDFromString
(
bstr
,
&
iid
);
ok
(
hr
==
S_OK
,
"IIDFromString error %#x
\n
"
,
hr
);
SysFreeString
(
bstr
);
IRegisteredTask_Release
(
task1
);
...
...
@@ -1006,7 +1010,10 @@ static void test_settings_v1(ITaskDefinition *taskdef, struct settings *test, st
if
(
!
def
->
restart_interval
[
0
])
ok
(
bstr
==
NULL
,
"expected NULL, got %s
\n
"
,
wine_dbgstr_w
(
bstr
));
else
{
ok
(
!
lstrcmpW
(
bstr
,
def
->
restart_interval
),
"expected %s, got %s
\n
"
,
wine_dbgstr_w
(
def
->
restart_interval
),
wine_dbgstr_w
(
bstr
));
SysFreeString
(
bstr
);
}
hr
=
ITaskSettings_get_RestartCount
(
set
,
&
vint
);
ok
(
hr
==
S_OK
,
"expected S_OK, got %#x
\n
"
,
hr
);
...
...
@@ -1052,7 +1059,10 @@ static void test_settings_v1(ITaskDefinition *taskdef, struct settings *test, st
if
(
!
test
->
delete_expired_task_after
[
0
])
ok
(
bstr
==
NULL
,
"expected NULL, got %s
\n
"
,
wine_dbgstr_w
(
bstr
));
else
{
ok
(
!
lstrcmpW
(
bstr
,
test
->
delete_expired_task_after
),
"expected %s, got %s
\n
"
,
wine_dbgstr_w
(
test
->
delete_expired_task_after
),
wine_dbgstr_w
(
bstr
));
SysFreeString
(
bstr
);
}
hr
=
ITaskSettings_get_Priority
(
set
,
&
vint
);
ok
(
hr
==
S_OK
,
"expected S_OK, got %#x
\n
"
,
hr
);
...
...
@@ -1094,7 +1104,11 @@ static void change_settings(ITaskDefinition *taskdef, struct settings *test)
todo_wine
ok
(
hr
==
S_OK
,
"expected S_OK, got %#x
\n
"
,
hr
);
/* FIXME: Remove once implemented */
if
(
hr
!=
S_OK
)
return
;
if
(
hr
!=
S_OK
)
{
ITaskSettings_Release
(
set
);
return
;
}
hr
=
ITaskSettings_put_RestartCount
(
set
,
test
->
restart_count
);
ok
(
hr
==
S_OK
,
"expected S_OK, got %#x
\n
"
,
hr
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment