msi: automation: Installer::Products, verify HeapAlloc return value.

5f2e81e2 · Misha Koshelev · Alexandre Julliard · 536b4990 · 5f2e81e2
Commit 5f2e81e2 authored May 14, 2007 by Misha Koshelev Committed by Alexandre Julliard May 15, 2007
Hide whitespace changes
Inline Side-by-side

Showing with 9 additions and 5 deletions

automation.c dlls/msi/automation.c +9 -5

No files found.
--- a/dlls/msi/automation.c
+++ b/dlls/msi/automation.c
@@ -1386,12 +1386,16 @@ static HRESULT WINAPI InstallerImpl_Invoke(

                    /* Save product strings */
                    sldata = (StringListData *)private_data((AutomationObject *)pDispatch);
-                    sldata->iCount = idx;
-                    sldata->pszStrings = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(LPWSTR)*sldata->iCount);
-                    for (idx = 0; idx < sldata->iCount; idx++)
+                    if (!(sldata->pszStrings = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(LPWSTR)*sldata->iCount)))
+                        ERR("Out of memory\n");
+                    else
                    {
-                        ret = MsiEnumProductsW(idx, szProductBuf);
-                        sldata->pszStrings[idx] = SysAllocString(szProductBuf);
+                        sldata->iCount = idx;
+                        for (idx = 0; idx < sldata->iCount; idx++)
+                        {
+                            ret = MsiEnumProductsW(idx, szProductBuf);
+                            sldata->pszStrings[idx] = SysAllocString(szProductBuf);
+                        }
                    }
                }
                else