msdasql: Support NULL dialect in GetCommandText.

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

msdasql: Support NULL dialect in GetCommandText.
5f8e3a0c · Alistair Leslie-Hughes · Alexandre Julliard · 0d29647f · 5f8e3a0c · 5f8e3a0c
Commit 5f8e3a0c authored Nov 16, 2021 by Alistair Leslie-Hughes Committed by Alexandre Julliard Nov 16, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 1 deletion

session.c dlls/msdasql/session.c +1 -1

provider.c dlls/msdasql/tests/provider.c +6 -0

No files found.
--- a/dlls/msdasql/session.c
+++ b/dlls/msdasql/session.c
@@ -910,7 +910,7 @@ static HRESULT WINAPI command_GetCommandText(ICommandText *iface, GUID *dialect,
    if (!command->query)
        return DB_E_NOCOMMAND;

-    if (!IsEqualGUID(&DBGUID_DEFAULT, dialect))
+    if (dialect && !IsEqualGUID(&DBGUID_DEFAULT, dialect))
    {
        *dialect = DBGUID_DEFAULT;
        hr = DB_S_DIALECTIGNORED;

--- a/dlls/msdasql/tests/provider.c
+++ b/dlls/msdasql/tests/provider.c
@@ -265,6 +265,12 @@ if (0)
    hr = ICommandText_SetCommandText(comand_text, &DBGUID_DEFAULT, L"select * from testing");
    ok(hr == S_OK, "got 0x%08x\n", hr);

+
+    hr = ICommandText_GetCommandText(comand_text, NULL, &str);
+    ok(hr == S_OK, "got 0x%08x\n", hr);
+    ok (!lstrcmpW(L"select * from testing", str), "got %s\n", debugstr_w(str));
+    HeapFree(GetProcessHeap(), 0, str);
+
    /* dialect empty value */
    hr = ICommandText_GetCommandText(comand_text, &dialect, &str);
    ok(hr == DB_S_DIALECTIGNORED, "got 0x%08x\n", hr);