winegcc: Prefer -Wl,--pdb=<file> over -Wl,-pdb,<file>.

The previously used syntax, -Wl,-pdb,<file>, was the originally supported one in lld (since 2018). Later (in 2019) the second syntax was added, allowing both -Wl,-pdb=<file> and -Wl,-pdb,<file>. (This other parameter syntax allows easier distinguishing an empty argument, for letting the linker implicitly pick the file name.) Move over to using the more modern syntax - reducing the usage of the old form of the option. This potentially allows deprecating the original syntax and maybe allows using --pdb as a boolean flag for implying an automatically named PDB file (which currently requires using the awkward syntax "--pdb="). Also prefer the long two dashes form, i.e. --pdb instead of -pdb; the single dash form is only allowed by getopt when there are no conflicts with single-letter options, while the form with two dashes is unambiguous.

winegcc: Prefer -Wl,--pdb=<file> over -Wl,-pdb,<file>.
6705a710 · Martin Storsjö · Alexandre Julliard · 2d90027b · 6705a710
Commit 6705a710 authored Oct 20, 2022 by Martin Storsjö Committed by Alexandre Julliard Nov 01, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

winegcc.c tools/winegcc/winegcc.c +1 -1

No files found.
--- a/tools/winegcc/winegcc.c
+++ b/tools/winegcc/winegcc.c
@@ -464,7 +464,7 @@ static struct strarray get_link_args( struct options *opts, const char *output_n
            strarray_add( &flags, "-static-libgcc" );

        if (opts->debug_file && strendswith(opts->debug_file, ".pdb"))
-            strarray_add(&link_args, strmake("-Wl,-pdb,%s", opts->debug_file));
+            strarray_add(&link_args, strmake("-Wl,--pdb=%s", opts->debug_file));

        if (opts->out_implib)
            strarray_add(&link_args, strmake("-Wl,--out-implib,%s", opts->out_implib));