Make MSVCRT__sopen() complain louder about unknown oflags, but not

about _O_WRONLY. MSVCRT_fopen() should pass third argument to _open() because it may set _O_CREAT.

Make MSVCRT__sopen() complain louder about unknown oflags, but not
6d6d06a8 · Pavel Roskin · Alexandre Julliard · 367cf414 · 6d6d06a8
Commit 6d6d06a8 authored Oct 24, 2003 by Pavel Roskin Committed by Alexandre Julliard Oct 24, 2003
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 3 deletions

file.c dlls/msvcrt/file.c +3 -3

No files found.
--- a/dlls/msvcrt/file.c
+++ b/dlls/msvcrt/file.c
@@ -1028,8 +1028,8 @@ int MSVCRT__sopen( const char *path, int oflags, int shflags, ... )
  }

  if (oflags & ~(_O_BINARY|_O_TEXT|_O_APPEND|_O_TRUNC|_O_EXCL
-                |_O_CREAT|_O_RDWR|_O_TEMPORARY|_O_NOINHERIT))
-    TRACE(":unsupported oflags 0x%04x\n",oflags);
+                |_O_CREAT|_O_RDWR|_O_WRONLY|_O_TEMPORARY|_O_NOINHERIT))
+    ERR(":unsupported oflags 0x%04x\n",oflags);

  sa.nLength              = sizeof( SECURITY_ATTRIBUTES );
  sa.lpSecurityDescriptor = NULL;
@@ -1908,7 +1908,7 @@ MSVCRT_FILE* MSVCRT_fopen(const char *path, const char *mode)
      FIXME(":unknown flag %c not supported\n",mode[-1]);
    }

-  fd = _open(path, flags);
+  fd = _open(path, flags, _S_IREAD | _S_IWRITE);

  if (fd < 0)
    return NULL;