jscript: Fix value leak in Array.shift.

Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>

jscript: Fix value leak in Array.shift.
70087067 · Gabriel Ivăncescu · Alexandre Julliard · 0a4b70a5 · 70087067
Commit 70087067 authored Nov 03, 2023 by Gabriel Ivăncescu Committed by Alexandre Julliard Nov 03, 2023
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

array.c dlls/jscript/array.c +3 -1

No files found.
--- a/dlls/jscript/array.c
+++ b/dlls/jscript/array.c
@@ -527,8 +527,10 @@ static HRESULT Array_shift(script_ctx_t *ctx, jsval_t vthis, WORD flags, unsigne
        hres = jsdisp_get_idx(jsthis, i, &v);
        if(hres == DISP_E_UNKNOWNNAME)
            hres = jsdisp_delete_idx(jsthis, i-1);
-        else if(SUCCEEDED(hres))
+        else if(SUCCEEDED(hres)) {
            hres = jsdisp_propput_idx(jsthis, i-1, v);
+            jsval_release(v);
+        }
    }

    if(SUCCEEDED(hres)) {