wined3d: Avoid checking depth/stencil and compressed formats in init_format_fbo_compat_info().

Checking these is somewhat pointless since they should never be color-renderable according to the FBO spec. This patch also happens to avoid dereferencing a NULL pointer inside fglrx.

wined3d: Avoid checking depth/stencil and compressed formats in init_format_fbo_compat_info().
75995203 · Henri Verbeet · Alexandre Julliard · 669891c8 · 75995203
Commit 75995203 authored Jun 12, 2009 by Henri Verbeet Committed by Alexandre Julliard Jun 12, 2009
Hide whitespace changes
Inline Side-by-side

Showing with 14 additions and 0 deletions

utils.c dlls/wined3d/utils.c +14 -0

No files found.
--- a/dlls/wined3d/utils.c
+++ b/dlls/wined3d/utils.c
@@ -596,6 +596,20 @@ static void init_format_fbo_compat_info(WineD3D_GL_Info *gl_info)

        if (!desc->glInternal) continue;

+        if (desc->Flags & (WINED3DFMT_FLAG_DEPTH | WINED3DFMT_FLAG_STENCIL))
+        {
+            TRACE("Skipping format %s because it's a depth/stencil format.\n",
+                    debug_d3dformat(desc->format));
+            continue;
+        }
+
+        if (desc->Flags & WINED3DFMT_FLAG_COMPRESSED)
+        {
+            TRACE("Skipping format %s because it's a compressed format.\n",
+                    debug_d3dformat(desc->format));
+            continue;
+        }
+
        if (wined3d_settings.offscreen_rendering_mode == ORM_FBO)
        {
            TRACE("Checking if format %s is supported as FBO color attachment...\n", debug_d3dformat(desc->format));