krnl386.exe16: Don't overflow when calculating size.

The application again the bug, passed 1 as the elem parameter which doubled the memory being allocated. When it overflowed (became negative), the value was passed into GlobalAlloc16 which then failed. GlobalAlloc16 takes a DWORD parameter, so the value isn't going to be truncated. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53092 Original patch by github user cracyc for winevdm.

krnl386.exe16: Don't overflow when calculating size.
77e0aae7 · Alistair Leslie-Hughes · Alexandre Julliard · c1588b1b · 77e0aae7
Commit 77e0aae7 authored Jun 01, 2023 by Alistair Leslie-Hughes Committed by Alexandre Julliard Jun 01, 2023
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

ne_segment.c dlls/krnl386.exe16/ne_segment.c +1 -1

No files found.
--- a/dlls/krnl386.exe16/ne_segment.c
+++ b/dlls/krnl386.exe16/ne_segment.c
@@ -945,7 +945,7 @@ static WORD NE_Ne2MemFlags(WORD flags)
 */
 DWORD WINAPI MyAlloc16( WORD wFlags, WORD wSize, WORD wElem )
 {
-    WORD size = wSize << wElem;
+    DWORD size = wSize << wElem;
    HANDLE16 hMem = 0;

    if (wSize || (wFlags & NE_SEGFLAGS_MOVEABLE))