hhctrl: Fix memory leak on error path in resolve_filename (scan-build).

7b69313b · Alex Henrie · Alexandre Julliard · 2cabb3f7 · 7b69313b
Commit 7b69313b authored Jun 07, 2023 by Alex Henrie Committed by Alexandre Julliard Jun 07, 2023
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 1 deletion

hhctrl.c dlls/hhctrl.ocx/hhctrl.c +8 -1

No files found.
--- a/dlls/hhctrl.ocx/hhctrl.c
+++ b/dlls/hhctrl.ocx/hhctrl.c
@@ -148,7 +148,14 @@ static BOOL resolve_filename(const WCHAR *env_filename, WCHAR *fullname, DWORD b

    free(filename);

-    return (GetFileAttributesW(fullname) != INVALID_FILE_ATTRIBUTES);
+    if (GetFileAttributesW(fullname) == INVALID_FILE_ATTRIBUTES)
+    {
+        if (window) free(*window);
+        if (index) free(*index);
+        return FALSE;
+    }
+
+    return TRUE;
 }

 /******************************************************************