wined3d: Avoid reading freed memory when destroying shader resource views.

Signed-off-by: Stefan Dösinger <stefandoesinger@gmx.at> Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wined3d: Avoid reading freed memory when destroying shader resource views.
80348ec5 · Stefan Dösinger · Alexandre Julliard · 36a1bc1f · 80348ec5
Commit 80348ec5 authored Jul 03, 2016 by Stefan Dösinger Committed by Alexandre Julliard Jul 04, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

view.c dlls/wined3d/view.c +3 -2

No files found.
--- a/dlls/wined3d/view.c
+++ b/dlls/wined3d/view.c
@@ -228,13 +228,14 @@ ULONG CDECL wined3d_shader_resource_view_decref(struct wined3d_shader_resource_v

    if (!refcount)
    {
-        struct wined3d_device *device = view->resource->device;
+        struct wined3d_resource *resource = view->resource;
+        struct wined3d_device *device = resource->device;

        /* Call wined3d_object_destroyed() before releasing the resource,
         * since releasing the resource may end up destroying the parent. */
        view->parent_ops->wined3d_object_destroyed(view->parent);
-        wined3d_resource_decref(view->resource);
        wined3d_cs_emit_destroy_object(device->cs, wined3d_shader_resource_view_destroy_object, view);
+        wined3d_resource_decref(resource);
    }

    return refcount;