mlang: Fix memory leaks in error path (found by Smatch).

8ae0d17d · Lionel_Debroux · Alexandre Julliard · 03f3a40a · 8ae0d17d
Commit 8ae0d17d authored Sep 26, 2007 by Lionel_Debroux Committed by Alexandre Julliard Sep 27, 2007
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 3 deletions

mlang.c dlls/mlang/mlang.c +2 -3

No files found.
--- a/dlls/mlang/mlang.c
+++ b/dlls/mlang/mlang.c
@@ -634,10 +634,9 @@ HRESULT WINAPI ConvertINetString(

        pDstStrW = HeapAlloc(GetProcessHeap(), 0, cDstSizeW * sizeof(WCHAR));
        hr = ConvertINetMultiByteToUnicode(pdwMode, dwSrcEncoding, pSrcStr, pcSrcSize, pDstStrW, &cDstSizeW);
-        if (hr != S_OK)
-            return hr;
+        if (hr == S_OK)
+            hr = ConvertINetUnicodeToMultiByte(pdwMode, dwDstEncoding, pDstStrW, &cDstSizeW, pDstStr, pcDstSize);

-        hr = ConvertINetUnicodeToMultiByte(pdwMode, dwDstEncoding, pDstStrW, &cDstSizeW, pDstStr, pcDstSize);
        HeapFree(GetProcessHeap(), 0, pDstStrW);
        return hr;
    }