gdiplus: Fix cleanup after errors in GdipCloneImage.

8b154a59 · Vincent Povirk · Alexandre Julliard · bf04d3fa · 8b154a59
Commit 8b154a59 authored Dec 06, 2009 by Vincent Povirk Committed by Alexandre Julliard Dec 07, 2009
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

image.c dlls/gdiplus/image.c +4 -2

No files found.
--- a/dlls/gdiplus/image.c
+++ b/dlls/gdiplus/image.c
@@ -746,12 +746,14 @@ GpStatus WINGDIPAPI GdipCloneImage(GpImage *image, GpImage **cloneImage)
                GdipBitmapUnlockBits((GpBitmap*)*cloneImage, &lockeddata_dst);
            }

-            GdipBitmapUnlockBits(bitmap, &lockeddata_src);
+            if (stat != Ok)
+                GdipDisposeImage(*cloneImage);
        }

+        GdipBitmapUnlockBits(bitmap, &lockeddata_src);
+
        if (stat != Ok)
        {
-            GdipDisposeImage(*cloneImage);
            *cloneImage = NULL;
        }
        else memcpy(&(*cloneImage)->format, &image->format, sizeof(GUID));