riched20: Obtain the composition start index after deleting selection.

Today, the Rich Edit control handles the WM_IME_STARTCOMPOSITION message by the computing the composition start position (imeStartIndex) _before_ calling ME_DeleteSelection(), which shifts the character positions after the range of deletion. If the selection were not empty, imeStartIndex immediately becomes stale, since it does not take into account the number of deleted characters before it. Fix this by computing imeStartIndex after the ME_DeleteSelection() call. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54318

riched20: Obtain the composition start index after deleting selection.
8c43577f · Jinoh Kang · Alexandre Julliard · 8b0868c1 · 8c43577f
Commit 8c43577f authored Jan 24, 2023 by Jinoh Kang Committed by Alexandre Julliard Jan 24, 2023
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

editor.c dlls/riched20/editor.c +1 -1

No files found.
--- a/dlls/riched20/editor.c
+++ b/dlls/riched20/editor.c
@@ -4099,8 +4099,8 @@ LRESULT editor_handle_message( ME_TextEditor *editor, UINT msg, WPARAM wParam,
    return 0;
  case WM_IME_STARTCOMPOSITION:
  {
-    editor->imeStartIndex=ME_GetCursorOfs(&editor->pCursors[0]);
    ME_DeleteSelection(editor);
+    editor->imeStartIndex = ME_GetCursorOfs(&editor->pCursors[0]);
    ME_CommitUndo(editor);
    ME_UpdateRepaint(editor, FALSE);
    return 0;