Better handling of errors in RenderFile.

8d019114 · Christian Costa · Alexandre Julliard · 9cc5c157 · 8d019114
Commit 8d019114 authored Dec 06, 2004 by Christian Costa Committed by Alexandre Julliard Dec 06, 2004
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 3 deletions

filtergraph.c dlls/quartz/filtergraph.c +4 -3

No files found.
--- a/dlls/quartz/filtergraph.c
+++ b/dlls/quartz/filtergraph.c
@@ -949,7 +949,8 @@ static HRESULT WINAPI Graphbuilder_RenderFile(IGraphBuilder *iface,
    }

    /* Render all output pin of the splitter by calling IGraphBuilder_Render on each of them */
-    hr = GetInternalConnections(psplitter, ppinsplitter, &ppins, &nb);
+    if (SUCCEEDED(hr))
+        hr = GetInternalConnections(psplitter, ppinsplitter, &ppins, &nb);
    
    if (SUCCEEDED(hr)) {
        int i;
@@ -963,10 +964,10 @@ static HRESULT WINAPI Graphbuilder_RenderFile(IGraphBuilder *iface,
                break;
            }
        }
+        CoTaskMemFree(ppins);
    }
-    CoTaskMemFree(ppins);
    
-    return S_OK;
+    return hr;
 }

 static HRESULT WINAPI Graphbuilder_AddSourceFilter(IGraphBuilder *iface,