oleaut32: Improve error handling in GetRecordInfoFromTypeInfo() (Coverity).

8d4f5681 · Nikolay Sivov · Alexandre Julliard · a260d3ef · 8d4f5681
Commit 8d4f5681 authored Jun 03, 2015 by Nikolay Sivov Committed by Alexandre Julliard Jun 03, 2015
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 1 deletion

recinfo.c dlls/oleaut32/recinfo.c +6 -1

No files found.
--- a/dlls/oleaut32/recinfo.c
+++ b/dlls/oleaut32/recinfo.c
@@ -650,7 +650,12 @@ HRESULT WINAPI GetRecordInfoFromTypeInfo(ITypeInfo* pTI, IRecordInfo** ppRecInfo
            WARN("GetRefTypeInfo failed: %08x\n", hres);
            return hres;
        }
-        ITypeInfo_GetTypeAttr(pTypeInfo, &typeattr);
+        hres = ITypeInfo_GetTypeAttr(pTypeInfo, &typeattr);
+        if(FAILED(hres)) {
+            ITypeInfo_Release(pTypeInfo);
+            WARN("GetTypeAttr failed for referenced type: %08x\n", hres);
+            return hres;
+        }
    }else  {
        pTypeInfo = pTI;
        ITypeInfo_AddRef(pTypeInfo);