Commit 91afe981 authored by Robert Shearman's avatar Robert Shearman Committed by Alexandre Julliard

ole32: Fix infinite recursion in CompositeMonikerImpl_BindToStorage.

parent efe9ceda
...@@ -402,7 +402,7 @@ CompositeMonikerImpl_BindToStorage(IMoniker* iface, IBindCtx* pbc, ...@@ -402,7 +402,7 @@ CompositeMonikerImpl_BindToStorage(IMoniker* iface, IBindCtx* pbc,
IMoniker* pmkToLeft, REFIID riid, VOID** ppvResult) IMoniker* pmkToLeft, REFIID riid, VOID** ppvResult)
{ {
HRESULT res; HRESULT res;
IMoniker *tempMk,*antiMk,*mostRigthMk; IMoniker *tempMk,*antiMk,*mostRigthMk,*leftMk;
IEnumMoniker *enumMoniker; IEnumMoniker *enumMoniker;
TRACE("(%p,%p,%p,%p,%p)\n",iface,pbc,pmkToLeft,riid,ppvResult); TRACE("(%p,%p,%p,%p,%p)\n",iface,pbc,pmkToLeft,riid,ppvResult);
...@@ -412,26 +412,34 @@ CompositeMonikerImpl_BindToStorage(IMoniker* iface, IBindCtx* pbc, ...@@ -412,26 +412,34 @@ CompositeMonikerImpl_BindToStorage(IMoniker* iface, IBindCtx* pbc,
/* This method recursively calls BindToStorage on the rightmost component of the composite, */ /* This method recursively calls BindToStorage on the rightmost component of the composite, */
/* passing the rest of the composite as the pmkToLeft parameter for that call. */ /* passing the rest of the composite as the pmkToLeft parameter for that call. */
if (pmkToLeft!=NULL){ if (pmkToLeft)
{
res = IMoniker_ComposeWith(pmkToLeft, iface, FALSE, &leftMk);
if (FAILED(res)) return res;
}
else
leftMk = iface;
IMoniker_Enum(iface,FALSE,&enumMoniker); IMoniker_Enum(iface, FALSE, &enumMoniker);
IEnumMoniker_Next(enumMoniker,1,&mostRigthMk,NULL); IEnumMoniker_Next(enumMoniker, 1, &mostRigthMk, NULL);
IEnumMoniker_Release(enumMoniker); IEnumMoniker_Release(enumMoniker);
res=CreateAntiMoniker(&antiMk); res = CreateAntiMoniker(&antiMk);
res=IMoniker_ComposeWith(iface,antiMk,0,&tempMk); if (FAILED(res)) return res;
IMoniker_Release(antiMk); res = IMoniker_ComposeWith(leftMk, antiMk, 0, &tempMk);
if (FAILED(res)) return res;
IMoniker_Release(antiMk);
res=IMoniker_BindToStorage(mostRigthMk,pbc,tempMk,riid,ppvResult); res = IMoniker_BindToStorage(mostRigthMk, pbc, tempMk, riid, ppvResult);
IMoniker_Release(tempMk); IMoniker_Release(tempMk);
IMoniker_Release(mostRigthMk); IMoniker_Release(mostRigthMk);
return res; if (pmkToLeft)
} IMoniker_Release(leftMk);
else
return IMoniker_BindToStorage(iface,pbc,NULL,riid,ppvResult); return res;
} }
/****************************************************************************** /******************************************************************************
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment