Commit 91dcf287 authored by Jacek Caban's avatar Jacek Caban Committed by Alexandre Julliard

mshtml: Fixed argument checking in IHTMLDOMChildrenCollection::item.

parent 8d7066b2
...@@ -166,7 +166,7 @@ static HRESULT WINAPI HTMLDOMChildrenCollection_item(IHTMLDOMChildrenCollection ...@@ -166,7 +166,7 @@ static HRESULT WINAPI HTMLDOMChildrenCollection_item(IHTMLDOMChildrenCollection
TRACE("(%p)->(%ld %p)\n", This, index, ppItem); TRACE("(%p)->(%ld %p)\n", This, index, ppItem);
nsIDOMNodeList_GetLength(This->nslist, &length); nsIDOMNodeList_GetLength(This->nslist, &length);
if(index < 0 || index > length) if(index < 0 || index >= length)
return E_INVALIDARG; return E_INVALIDARG;
nsres = nsIDOMNodeList_Item(This->nslist, index, &nsnode); nsres = nsIDOMNodeList_Item(This->nslist, index, &nsnode);
......
...@@ -2042,6 +2042,11 @@ static void test_elems(IHTMLDocument2 *doc) ...@@ -2042,6 +2042,11 @@ static void test_elems(IHTMLDocument2 *doc)
ok(hres == E_INVALIDARG, "item failed: %08x, expected E_INVALIDARG\n", hres); ok(hres == E_INVALIDARG, "item failed: %08x, expected E_INVALIDARG\n", hres);
ok(disp == (void*)0xdeadbeef, "disp=%p\n", disp); ok(disp == (void*)0xdeadbeef, "disp=%p\n", disp);
disp = (void*)0xdeadbeef;
hres = IHTMLDOMChildrenCollection_item(child_col, length, &disp);
ok(hres == E_INVALIDARG, "item failed: %08x, expected E_INVALIDARG\n", hres);
ok(disp == (void*)0xdeadbeef, "disp=%p\n", disp);
test_child_col_disp(child_col); test_child_col_disp(child_col);
IHTMLDOMChildrenCollection_Release(child_col); IHTMLDOMChildrenCollection_Release(child_col);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment