ws2_32: Win NT4 does not zero the sockaddr_in structure on getsockname.

All other versions of windows do, and this makes native dplay traces much more readable, which is why Wine implements this as well. Mark NT4 as broken, to make sure Wine doesn't regress.

ws2_32: Win NT4 does not zero the sockaddr_in structure on getsockname.
93f1d487 · Kai Blin · Alexandre Julliard · 10090eb2 · 93f1d487
Commit 93f1d487 authored Sep 11, 2008 by Kai Blin Committed by Alexandre Julliard Sep 11, 2008
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

sock.c dlls/ws2_32/tests/sock.c +3 -1

No files found.
--- a/dlls/ws2_32/tests/sock.c
+++ b/dlls/ws2_32/tests/sock.c
@@ -1858,6 +1858,7 @@ static void test_getsockname(void)
    int sa_set_len = sizeof(struct sockaddr_in);
    int sa_get_len = sa_set_len;
    static const unsigned char null_padding[] = {0,0,0,0,0,0,0,0};
+    int ret;
    if(WSAStartup(MAKEWORD(2,0), &wsa)){
        trace("Winsock failed: %d. Aborting test\n", WSAGetLastError());
@@ -1900,7 +1901,8 @@ static void test_getsockname(void)
        return;
    }
-    ok(memcmp(sa_get.sin_zero, null_padding, 8) == 0,
+    ret = memcmp(sa_get.sin_zero, null_padding, 8);
+    ok(ret == 0 || broken(ret != 0), /* NT4 */
            "getsockname did not zero the sockaddr_in structure\n");
    closesocket(sock);