Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-cw
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-cw
Commits
a2fdae65
Commit
a2fdae65
authored
Nov 25, 2023
by
Zhiyi Zhang
Committed by
Alexandre Julliard
Nov 27, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
wbemprox: Fix a memory leak (Coverity).
When LsaLookupSids() fails with STATUS_NONE_MAPPED or STATUS_SOME_NOT_MAPPED, the memory returned by the domain parameter should be freed.
parent
1ab1c970
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
1 deletion
+4
-1
builtin.c
dlls/wbemprox/builtin.c
+4
-1
No files found.
dlls/wbemprox/builtin.c
View file @
a2fdae65
...
@@ -3982,6 +3982,7 @@ static enum fill_status fill_sid( struct table *table, const struct expr *cond )
...
@@ -3982,6 +3982,7 @@ static enum fill_status fill_sid( struct table *table, const struct expr *cond )
const
WCHAR
*
str
;
const
WCHAR
*
str
;
struct
record_sid
*
rec
;
struct
record_sid
*
rec
;
UINT
len
;
UINT
len
;
NTSTATUS
status
;
if
(
!
(
str
=
find_sid_str
(
cond
)))
return
FILL_STATUS_FAILED
;
if
(
!
(
str
=
find_sid_str
(
cond
)))
return
FILL_STATUS_FAILED
;
if
(
!
resize_table
(
table
,
1
,
sizeof
(
*
rec
)
))
return
FILL_STATUS_FAILED
;
if
(
!
resize_table
(
table
,
1
,
sizeof
(
*
rec
)
))
return
FILL_STATUS_FAILED
;
...
@@ -3996,10 +3997,12 @@ static enum fill_status fill_sid( struct table *table, const struct expr *cond )
...
@@ -3996,10 +3997,12 @@ static enum fill_status fill_sid( struct table *table, const struct expr *cond )
LocalFree
(
sid
);
LocalFree
(
sid
);
return
FILL_STATUS_FAILED
;
return
FILL_STATUS_FAILED
;
}
}
if
(
LsaLookupSids
(
handle
,
1
,
&
sid
,
&
domain
,
&
name
))
if
(
(
status
=
LsaLookupSids
(
handle
,
1
,
&
sid
,
&
domain
,
&
name
)
))
{
{
LocalFree
(
sid
);
LocalFree
(
sid
);
LsaClose
(
handle
);
LsaClose
(
handle
);
if
(
status
==
STATUS_NONE_MAPPED
||
status
==
STATUS_SOME_NOT_MAPPED
)
LsaFreeMemory
(
domain
);
return
FILL_STATUS_FAILED
;
return
FILL_STATUS_FAILED
;
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment