dwrite: Trace GetPaletteEntries() failure (Coverity).

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

dwrite: Trace GetPaletteEntries() failure (Coverity).
a8a6f0bd · Nikolay Sivov · Alexandre Julliard · f9b91b5a · a8a6f0bd
Commit a8a6f0bd authored Feb 20, 2016 by Nikolay Sivov Committed by Alexandre Julliard Feb 22, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 4 deletions

font.c dlls/dwrite/font.c +7 -4

No files found.
--- a/dlls/dwrite/font.c
+++ b/dlls/dwrite/font.c
@@ -4792,11 +4792,14 @@ static BOOL colorglyphenum_build_color_run(struct dwrite_colorglyphenum *glyphen
            if (!got_palette_index) {
                colorrun->paletteIndex = glyphenum->glyphs[g].palette_index;
                /* use foreground color or request one from the font */
-                if (colorrun->paletteIndex == 0xffff)
+                memset(&colorrun->runColor, 0, sizeof(colorrun->runColor));
-                    memset(&colorrun->runColor, 0, sizeof(colorrun->runColor));
+                if (colorrun->paletteIndex != 0xffff) {
-                else
+                    HRESULT hr = IDWriteFontFace2_GetPaletteEntries(glyphenum->fontface, glyphenum->palette, colorrun->paletteIndex,
-                    IDWriteFontFace2_GetPaletteEntries(glyphenum->fontface, glyphenum->palette, colorrun->paletteIndex,
                        1, &colorrun->runColor);
+                    if (FAILED(hr))
+                        WARN("failed to get palette entry, fontface %p, palette %u, index %u, 0x%08x\n", glyphenum->fontface,
+                            glyphenum->palette, colorrun->paletteIndex, hr);
+                }
                /* found a glyph position new color run starts from, origin is "original origin + distance to this glyph" */
                colorrun->baselineOriginX = glyphenum->origin_x + get_glyph_origin(glyphenum, g);
                colorrun->baselineOriginY = glyphenum->origin_y;