opcservices: Improve error handling (Coverity).

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

opcservices: Improve error handling (Coverity).
ab462acf · Nikolay Sivov · Alexandre Julliard · c1982f5d · ab462acf
Commit ab462acf authored Sep 19, 2018 by Nikolay Sivov Committed by Alexandre Julliard Sep 19, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 6 deletions

package.c dlls/opcservices/package.c +6 -6

No files found.
--- a/dlls/opcservices/package.c
+++ b/dlls/opcservices/package.c
@@ -1476,9 +1476,9 @@ static HRESULT opc_package_write_contenttypes(struct zip_archive *archive, IXmlW
    if (FAILED(hr = CreateStreamOnHGlobal(NULL, TRUE, &content)))
        return hr;

-    IXmlWriter_SetOutput(writer, (IUnknown *)content);
-
-    hr = IXmlWriter_WriteStartDocument(writer, XmlStandalone_Omit);
+    hr = IXmlWriter_SetOutput(writer, (IUnknown *)content);
+    if (SUCCEEDED(hr))
+        hr = IXmlWriter_WriteStartDocument(writer, XmlStandalone_Omit);
    if (SUCCEEDED(hr))
        hr = IXmlWriter_WriteStartElement(writer, NULL, typesW, uriW);
    if (SUCCEEDED(hr))
@@ -1566,9 +1566,9 @@ static HRESULT opc_package_write_rels(struct zip_archive *archive, IOpcRelations
        return hr;
    }

-    IXmlWriter_SetOutput(writer, (IUnknown *)content);
-
-    hr = IXmlWriter_WriteStartDocument(writer, XmlStandalone_Yes);
+    hr = IXmlWriter_SetOutput(writer, (IUnknown *)content);
+    if (SUCCEEDED(hr))
+        hr = IXmlWriter_WriteStartDocument(writer, XmlStandalone_Yes);
    if (SUCCEEDED(hr))
        hr = IXmlWriter_WriteStartElement(writer, NULL, relationshipsW, uriW);