Skip to content

W
wine-cw
Commit adde9fad authored by Jan Schmidt's avatar Jan Schmidt Committed by Alexandre Julliard
Browse files
Options

winegstreamer: Fix refcounting for videoflip.

Creating an element and placing it in a bin gives overship of the element refcount to the bin. Don't explicitly unref it after that. Signed-off-by: 's avatarJan Schmidt <jan@centricular.com> Signed-off-by: 's avatarAndrew Eikum <aeikum@codeweavers.com> Signed-off-by: 's avatarAlexandre Julliard <julliard@winehq.org>
parent 4aefacd1
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 5 deletions
dlls/winegstreamer/gstdemux.c
View file @ adde9fad
...@@ -864,7 +864,6 @@ static void init_new_decoded_pad(GstElement *bin, GstPad *pad, GSTImpl *This) ...@@ -864,7 +864,6 @@ static void init_new_decoded_pad(GstElement *bin, GstPad *pad, GSTImpl *This)
pin->flip_sink = gst_element_get_static_pad(vconv, "sink"); pin->flip_sink = gst_element_get_static_pad(vconv, "sink");
if(!pin->flip_sink){ if(!pin->flip_sink){
WARN("Couldn't find sink on flip filter\n"); WARN("Couldn't find sink on flip filter\n");
gst_object_unref(pin->flipfilter);
pin->flipfilter = NULL; pin->flipfilter = NULL;
ret = -1; ret = -1;
goto exit; goto exit;
...@@ -875,7 +874,6 @@ static void init_new_decoded_pad(GstElement *bin, GstPad *pad, GSTImpl *This) ...@@ -875,7 +874,6 @@ static void init_new_decoded_pad(GstElement *bin, GstPad *pad, GSTImpl *This)
WARN("gst_pad_link failed: %d\n", ret); WARN("gst_pad_link failed: %d\n", ret);
gst_object_unref(pin->flip_sink); gst_object_unref(pin->flip_sink);
pin->flip_sink = NULL; pin->flip_sink = NULL;
gst_object_unref(pin->flipfilter);
pin->flipfilter = NULL; pin->flipfilter = NULL;
goto exit; goto exit;
} }
...@@ -885,7 +883,6 @@ static void init_new_decoded_pad(GstElement *bin, GstPad *pad, GSTImpl *This) ...@@ -885,7 +883,6 @@ static void init_new_decoded_pad(GstElement *bin, GstPad *pad, GSTImpl *This)
WARN("Couldn't find src on flip filter\n"); WARN("Couldn't find src on flip filter\n");
gst_object_unref(pin->flip_sink); gst_object_unref(pin->flip_sink);
pin->flip_sink = NULL; pin->flip_sink = NULL;
gst_object_unref(pin->flipfilter);
pin->flipfilter = NULL; pin->flipfilter = NULL;
ret = -1; ret = -1;
goto exit; goto exit;
...@@ -898,7 +895,6 @@ static void init_new_decoded_pad(GstElement *bin, GstPad *pad, GSTImpl *This) ...@@ -898,7 +895,6 @@ static void init_new_decoded_pad(GstElement *bin, GstPad *pad, GSTImpl *This)
pin->flip_src = NULL; pin->flip_src = NULL;
gst_object_unref(pin->flip_sink); gst_object_unref(pin->flip_sink);
pin->flip_sink = NULL; pin->flip_sink = NULL;
gst_object_unref(pin->flipfilter);
pin->flipfilter = NULL; pin->flipfilter = NULL;
goto exit; goto exit;
} }
...@@ -1760,7 +1756,8 @@ static ULONG WINAPI GSTOutPin_Release(IPin *iface) ...@@ -1760,7 +1756,8 @@ static ULONG WINAPI GSTOutPin_Release(IPin *iface)
gst_pad_unlink(This->flip_src, This->my_sink); gst_pad_unlink(This->flip_src, This->my_sink);
gst_object_unref(This->flip_src); gst_object_unref(This->flip_src);
gst_object_unref(This->flip_sink); gst_object_unref(This->flip_sink);
gst_object_unref(This->flipfilter); This->flipfilter = NULL;
This->flip_src = This->flip_sink = NULL;
} else } else
gst_pad_unlink(This->their_src, This->my_sink); gst_pad_unlink(This->their_src, This->my_sink);
gst_object_unref(This->their_src); gst_object_unref(This->their_src);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment