shell32/tests: Return early if the shell folder creation fails in order to avoid…

shell32/tests: Return early if the shell folder creation fails in order to avoid a compiler warning. Signed-off-by: Huw Davies <huw@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

shell32/tests: Return early if the shell folder creation fails in order to avoid…
aef764d3 · Huw Davies · Alexandre Julliard · 858c07f6 · aef764d3
Commit aef764d3 authored Mar 17, 2017 by Huw Davies Committed by Alexandre Julliard Mar 17, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

shlfolder.c dlls/shell32/tests/shlfolder.c +2 -2

No files found.
--- a/dlls/shell32/tests/shlfolder.c
+++ b/dlls/shell32/tests/shlfolder.c
@@ -3800,10 +3800,10 @@ static void test_ShellItemArrayEnumItems(void)
        hr = IShellFolder_BindToObject(pdesktopsf, pidl_testdir, NULL, (REFIID)&IID_IShellFolder,
                                       (void**)&psf);
        ok(hr == S_OK, "Got 0x%08x\n", hr);
-        if(SUCCEEDED(hr))
-            pILFree(pidl_testdir);
+        pILFree(pidl_testdir);
    }
    IShellFolder_Release(pdesktopsf);
+    if (FAILED(hr)) return;

    hr = IShellFolder_EnumObjects(psf, NULL, SHCONTF_FOLDERS | SHCONTF_NONFOLDERS, &peidl);
    ok(hr == S_OK, "Got %08x\n", hr);